Skip to content

fix: triager guide broken link - #2415

Closed
mkco0 wants to merge 2 commits into
expressjs:mainfrom
mkco0:bugfix/triager-guide-link
Closed

fix: triager guide broken link#2415
mkco0 wants to merge 2 commits into
expressjs:mainfrom
mkco0:bugfix/triager-guide-link

Conversation

@mkco0

@mkco0 mkco0 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@mkco0
mkco0 requested a review from a team as a code owner June 30, 2026 16:37
@netlify

netlify Bot commented Jun 30, 2026

Copy link
Copy Markdown

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 76b1f7f
🔍 Latest deploy log https://app.netlify.com/projects/expressjscom-preview/deploys/6a43f13e2badab000885ba9f
😎 Deploy Preview https://deploy-preview-2415--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@mkco0 mkco0 closed this Jun 30, 2026
@mkco0 mkco0 reopened this Jun 30, 2026
@krzysdz

krzysdz commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

This part of this file is updated automatically from https://github.com/expressjs/discussions/blob/master/docs/GOVERNANCE.md.

{/* SRC: expressjs/discussions docs/GOVERNANCE.md */}

It looks like the script has problems with relative URLs. The URL was last updated in source in expressjs/discussions#489, and the changes have been pulled automatically in #2315.

@mkco0

mkco0 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

I see, thanks for the clarification about the script, I wasn't aware of that. I'll close my pull request and open an issue while trying to figure out what's wrong with the script.

@mkco0 mkco0 closed this Jun 30, 2026
@krzysdz

krzysdz commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

I'll close my pull request and open an issue while trying to figure out what's wrong with the script.

Here is the part that modifies links. It adds always the same prefix, but URLs that do not start with / are relative to the directory of the source file

# Convert relative links to absolute GitHub URLs
BASEURL="https://github.com/${repo}/blob/HEAD"
RAW=$(echo "$RAW" | sed -E "s|\]\(([^)#/][^):]*)\)|](${BASEURL}/\1)|g")

@mkco0
mkco0 deleted the bugfix/triager-guide-link branch June 30, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants